Proper ettiquette when extending someone else's work?

[Grim]

I rolled up my sleeves recently and started work on a Persistent Journal system using NWNX2. I know there are already several options out there for doing this, but I wanted to use this as a project to help me understand how to really use the ODBC extension to NWNX2.

I have never really gotten into scripting because other members on our team have that skill and I just ran the systems stuff. Now that we're using MySQL and because I have significant database experience, I'm starting to learn scripting to build some of the cool things we hope to achieve utilizing NWNX2.

All that being said, here is my question. I have been looking at Knat's Persistent Quest and Journal scripts to serve as a blueprint for how I might implement some of our desired functionality.

In his work he has a function called AddPersistentJournalQuestEntry. I'm going to have a very similar function in my script and at first thought of using the same name, but then thought that might be bad practice. I already plan to credit his work, but should I just prefix all of my functions with something new so there is a clear distinction and doesn't cause any confustion?

Thoughts?
_________________
Grim Havoc
Systems guy for Mists of the Mordri
(now private)

[Liberty Valance]

I would definitely recommend prefixing (if not renaming) your functions... if you decide to publicize your work later, it will prevent conflicts in other modules which have Knat's system already installed, and even if you don't, it can help to clarify that it's a custom function.

Good to hear that you're giving credit though... all too often I see stuff that's obviously based off other work, with no credit given, and even I've sometimes simply forgotten to do so (although revisions of my work include it once I've noticed).
_________________
A Persistent World West2 | APWW2 Forums
Wirehead Studios

[DarkstarsDad]

I agree Adding a uniique prefix too your scripting can make it easier for someone else to identify it if you do release it publicly. And it can make it alot easier for the other members of your team to tell what the scripts are when you are working with multiple people on the same module. This can save alot of searching for them (and you) if the module gets large. I have found keeping the script names standardised can save hours of searching during debug and changes.