Duplicate function errors

[Mal]

Hi everyone,

With help from a few of you here I have managed to get nwnx running and the server restarting on its own.. So thank you for the help you have given me so far.

Now, I am working at creating my own scripts to prevent the death, spell and hp logging exploits. While I have seen some scripts available on nwvault. I felt it was a good starting exercise at learning how to use the new persistent database functions with nwnx.

I am getting some strange behavior from the aps_include file and am hoping someone can give me a clue. When I add the include "aps_include" to the top of some of my scripts and compile them I get duplicate function errors. When in the nwn toolset script editor there will be two of the same functions listed at the right under the functions panel. When i take the include file back out and recompile the duplicate error goes away. What is really stumping me is that it doesn't happen with every script that I try to add the include file to. Some compile just fine and some duplicate functions. I am at a loss at this point as to what could cause this. Also, it is not always the same function getting duplicated. But, I know the duplicates are coming from the include file because they go away when I remove the include and recompile.

Ok I am starting to confuse myself so hopefully I explained what was going one well enough.

Thanks,

-Mal

[Baaleos]

If you are getting a message that says that you have duplicate functions, it is possible you do.


Go find the name of your duplicate function, and then search through your script to find anything with the same name.

Also remember to search include files.


if you have SetPersistentInt() inside your aps_include
and
if you have SetPersistentInt() inside another include file at the same time, they will both try to be read and loaded into memory, causing the error.

[Mal]

I willl look into all the includes again. I thought that may be the problem as well and checked for that but I will take another look.

It was thorowing me off because when the aps_include is part of the compile the duplicate functions show up in the function list as two of the same name. When I remove the aps_include file from the compile, both of the duplicate functions go away.
This would make me think that both of the functions are in the aps include file. However, I can add the same aps include file to a different script and i get no errors on compile.

-Mal

[Mal]

Ok, I figured it out how to stop the duplicate function errors. It seems that any scripts that I try to add the aps include file to that also have the horse system included as well give me duplicate function errors as the horse includes have the same function names. These are StringToVector, LocationToString, StringToLocation, and VectorToString.

What I have done to solve this is change the functions in the aps include file to
apsLocationToString, apsStringToLocation etc... then changed the rest of the aps_include file accordingly.

Does this seem like a good way to do this or does someone else have a better way?

Thanks,

-Mal

[Baaleos]

You can separate your calling script, over two scripts.


eg
If aps_include and horsey_script have conflicting functions,

then have

aps_include in your main script


and then at the end of the main script, or whereever you need it done,

Put in

[Mal]

Hi thanks for that post Baaleos.

I did try to use execute scripts at first to get around the include errors. But, I got confused about how the ExecuteScript function works.

For instance,

If I wanted to set a persistent int on a player when they are a target of a spell such as Raise or Resurrection. In the raise and resurrection spell scripts the player being raised is identified as oTarget, so I would use

ExecuteScript(oTarget, "script name");

But in the script I am now executing I am having difficulty identifying the PC. It was easy when using the on rest, on respawn etc... events. But now I am having difficulty identifying my object ie.

[Baaleos]

When you execute a script on a target, that object is running the script, and can b used as Object_self. So object_self is what otarget becomes.

[Mal]

Thanks a lot Baaleos. That explains fully why it didn't work when I tried execute script before. Hmm... I have the death system working now going another route, but I am thinking that I like the "streamlining" idea.

Are there any performance issues with calling multiple execute scripts instead of having all the code in one script. I would imagine you can end up with alot more ncs files. Is that a problem?

Thanks,

-Mal

[Baaleos]

its true,
for each nss you have, an ncs file will be created.


But sometimes, streamlining with multiple files is a necessity, to get around conflicting include files.


For instance,
I had an issue, where shayans subrace engine, wouldnt work with funkyswerves Simtools, because their includes both 'included' too many functions.

The way to fix this, was to span the onClientEnter Script, over two scripts, performance wise, Executing a new script doesnt eat up any performance, since it is just the same as calling any function.

eg
SendMessageToPC() will run just as easilly as ExecuteScript

Of course, the Duration of the ExecuteScript may take longer, depending on the content of the script you are executing.

eg-
If you have a while loop inside it, which takes 25 seconds to finish, then, you will see 25 second delays potentially.
But it is up to you, to make sure your own scripts are efficient.

This streamlining method is just intended as a way to work arround limitations in the nwnscript compiler.

Eg - you can get compilers from the vault, which allow you to compile outside of nwntoolset, and these will not have the limitation on included functions.

But I never used them for the hassle.

[Mal]

Great information. I really appreciate the help that you have given me.

Sincerely,

-Mal