View previous topic :: View next topic |
Author |
Message |
zelkin
Joined: 18 Oct 2012 Posts: 5
|
Posted: Wed Jan 17, 2018 2:01 Post subject: |
|
|
If you want MaxRock work there is a branch on the "official" nwnx win32 Github: https://github.com/NWNX/nwnx2-win32/tree/maxrock
I get mine from there, and i think i fixed the leaks and errors in his nwnx_areas (testing here everything seems to be working, even SetAreaName), if you want i can give you the code. |
|
Back to top |
|
|
virusman
Joined: 30 Jan 2005 Posts: 1020 Location: Russia
|
Posted: Thu Jan 25, 2018 1:41 Post subject: |
|
|
Can you make a fork of that repo, commit patches on your fork and then open a PR?
NWNX Windows is a mess, everything is in different repos, I'd like to merge things but I don't really know which versions of nwnx_funcs/areas/chat/etc. work and which don't. If you can point in the right direction, I can merge those into the main repo. _________________ In Soviet Russia, NWN plays you! |
|
Back to top |
|
|
Baaleos
Joined: 02 Sep 2007 Posts: 830
|
Posted: Thu Jan 25, 2018 2:32 Post subject: |
|
|
I can help identify which ones are working the best.
Although the real issue comes from the fact that they all use various different versions of the nwnx api - some of which have different internals definitions.
So having them all within the same repo might be difficult |
|
Back to top |
|
|
virusman
Joined: 30 Jan 2005 Posts: 1020 Location: Russia
|
Posted: Thu Jan 25, 2018 22:27 Post subject: |
|
|
Thanks! Check your PM inbox _________________ In Soviet Russia, NWN plays you! |
|
Back to top |
|
|
zelkin
Joined: 18 Oct 2012 Posts: 5
|
Posted: Fri Jan 26, 2018 19:00 Post subject: |
|
|
I dont have too much experience with Git and dont know how to make pull requets and etc
But i added my fork of MaxRock nwnx on github. The url is: https://github.com/DanielmGoulart/nwnx-maxrock
You can check if its working correctly and add it to the official repo if you want. The only changes I did is in nwnx_areas and the sln to open in VS 2012 I guess. |
|
Back to top |
|
|
|